Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the platform flag from the docker build.sh #4522

Closed
xmfcx opened this issue Mar 6, 2024 · 1 comment
Closed

Remove the platform flag from the docker build.sh #4522

xmfcx opened this issue Mar 6, 2024 · 1 comment
Assignees
Labels
type:containers Docker containers, containerization of components, or container orchestration.

Comments

@xmfcx
Copy link
Contributor

xmfcx commented Mar 6, 2024

Follow up from:

@ambroise-arm

I know that the --platform option existed before this PR, but testing it now for the first time I can't cross-compile to aarch64 on an x86_64 machine, it fails during the compilation of Autoware with

#26 2700.1 --- stderr: ament_cmake_gen_version_h                                                                                                                                                           
#26 2700.1 CMake Error at /usr/share/cmake-3.22/Modules/CMakeDetermineCCompiler.cmake:49 (message):                                                                                                        
#26 2700.1   Could not find compiler set in environment variable CC:                                                                                                                                       
#26 2700.1                                                                                                                                                                                                 
#26 2700.1   /usr/lib/ccache/gcc.                                                                                                                                                                          
#26 2700.1 Call Stack (most recent call first):                                                                                                                                                            
#26 2700.1   CMakeLists.txt:2 (project)                                                                                                                                                                    
#26 2700.1                                                                                                                                                                                                 
#26 2700.1                                                                                                                                                                                                 
#26 2700.1 CMake Error: CMAKE_C_COMPILER not set, after EnableLanguage                                                                                                                                     
#26 2700.1 CMake Error: CMAKE_CXX_COMPILER not set, after EnableLanguage                                                                                                                                   
#26 2700.1 ---                                                                                                                                                                                             
#26 2700.1 Failed   <<< ament_cmake_gen_version_h [3.48s, exited with code 1]

I don't know if we currently make use of this flag anywhere (CI for example), or even if it was working before this PR. If it was working it should probably be fixed. If it was not working we may want to consider if it is a good idea to keep an option that doesn't work.

--set "*.platform=$platform" \

@mitsudome-r do you know about the history of this flag?

@xmfcx xmfcx added the type:containers Docker containers, containerization of components, or container orchestration. label Mar 6, 2024
@xmfcx
Copy link
Contributor Author

xmfcx commented Mar 6, 2024

Ok it was just ccache related, false alarm, closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:containers Docker containers, containerization of components, or container orchestration.
Projects
Status: Done
Development

No branches or pull requests

2 participants