Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more broken links #113

Merged
merged 12 commits into from
Sep 6, 2024
Merged

No more broken links #113

merged 12 commits into from
Sep 6, 2024

Conversation

owenwahlgren
Copy link
Contributor

a script and github action to check all .mdx files in the project for valid external links
yarn check-links

might want to consider if we run this every push vs only pull requests

Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
avalanche-academy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 9:16pm

package.json Outdated
@@ -14,6 +15,8 @@
"@noble/bls12-381": "^1.4.0",
"@vercel/analytics": "^1.3.1",
"@vercel/speed-insights": "^1.0.12",
"axios": "^1.7.7",
"cheerio": "^1.0.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make these dev dependencies?

@@ -35,6 +38,7 @@
"autoprefixer": "^10.4.19",
"postcss": "^8.4.39",
"tailwindcss": "^3.4.4",
"tsx": "^4.19.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@owenwahlgren owenwahlgren added the DO NOT MERGE This PR is not meant to be merged in its current state label Sep 6, 2024
@owenwahlgren owenwahlgren removed the DO NOT MERGE This PR is not meant to be merged in its current state label Sep 6, 2024
only check on PRs

Signed-off-by: Owen <[email protected]>
@martineckardt martineckardt merged commit f4d0413 into dev Sep 6, 2024
3 checks passed
@martineckardt martineckardt deleted the broken-links-cicd branch September 6, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants