Remove codec length check after Durango

api/keystore/codec.go

@@ -4,6 +4,8 @@
 package keystore
 
 import (
+	"time"
+
 	"github.com/ava-labs/avalanchego/codec"
 	"github.com/ava-labs/avalanchego/codec/linearcodec"
 	"github.com/ava-labs/avalanchego/utils/units"
@@ -12,14 +14,13 @@ import (
 const (
 	CodecVersion = 0
 
-	maxPackerSize  = 1 * units.GiB // max size, in bytes, of something being marshalled by Marshal()
-	maxSliceLength = linearcodec.DefaultMaxSliceLength
+	maxPackerSize = 1 * units.GiB // max size, in bytes, of something being marshalled by Marshal()
 )
 
 var Codec codec.Manager
 
 func init() {
-	lc := linearcodec.NewCustomMaxLength(maxSliceLength)
+	lc := linearcodec.NewDefault(time.Time{})
 	Codec = codec.NewManager(maxPackerSize)
 	if err := Codec.RegisterCodec(CodecVersion, lc); err != nil {
 		panic(err)

chains/atomic/codec.go

@@ -4,6 +4,9 @@
 package atomic
 
 import (
+	"math"
+	"time"
+
 	"github.com/ava-labs/avalanchego/codec"
 	"github.com/ava-labs/avalanchego/codec/linearcodec"
 )
@@ -14,8 +17,8 @@ const CodecVersion = 0
 var Codec codec.Manager
 
 func init() {
-	lc := linearcodec.NewDefault()
-	Codec = codec.NewDefaultManager()
+	lc := linearcodec.NewDefault(time.Time{})
+	Codec = codec.NewManager(math.MaxInt)
 	if err := Codec.RegisterCodec(CodecVersion, lc); err != nil {
 		panic(err)
 	}

codec/hierarchycodec/codec.go

@@ -7,6 +7,7 @@ import (
 	"fmt"
 	"reflect"
 	"sync"
+	"time"
 
 	"github.com/ava-labs/avalanchego/codec"
 	"github.com/ava-labs/avalanchego/codec/reflectcodec"
@@ -50,19 +51,19 @@ type hierarchyCodec struct {
 }
 
 // New returns a new, concurrency-safe codec
-func New(tagNames []string, maxSliceLen uint32) Codec {
+func New(durangoTime time.Time, tagNames []string, maxSliceLen uint32) Codec {
 	hCodec := &hierarchyCodec{
 		currentGroupID:  0,
 		nextTypeID:      0,
 		registeredTypes: bimap.New[typeID, reflect.Type](),
 	}
-	hCodec.Codec = reflectcodec.New(hCodec, tagNames, maxSliceLen)
+	hCodec.Codec = reflectcodec.New(hCodec, tagNames, durangoTime, maxSliceLen)
 	return hCodec
 }
 
 // NewDefault returns a new codec with reasonable default values
-func NewDefault() Codec {
-	return New([]string{reflectcodec.DefaultTagName}, defaultMaxSliceLength)
+func NewDefault(durangoTime time.Time) Codec {
+	return New(durangoTime, []string{reflectcodec.DefaultTagName}, defaultMaxSliceLength)
 }
 
 // SkipRegistrations some number of type IDs

codec/hierarchycodec/codec_test.go

@@ -7,23 +7,24 @@ import (
 	"testing"
 
 	"github.com/ava-labs/avalanchego/codec"
+	"github.com/ava-labs/avalanchego/utils/timer/mockable"
 )
 
 func TestVectors(t *testing.T) {
 	for _, test := range codec.Tests {
-		c := NewDefault()
+		c := NewDefault(mockable.MaxTime)
 		test(c, t)
 	}
 }
 
 func TestMultipleTags(t *testing.T) {
 	for _, test := range codec.MultipleTagsTests {
-		c := New([]string{"tag1", "tag2"}, defaultMaxSliceLength)
+		c := New(mockable.MaxTime, []string{"tag1", "tag2"}, defaultMaxSliceLength)
 		test(c, t)
 	}
 }
 
 func FuzzStructUnmarshalHierarchyCodec(f *testing.F) {
-	c := NewDefault()
+	c := NewDefault(mockable.MaxTime)
 	codec.FuzzStructUnmarshal(c, f)
 }

codec/linearcodec/codec.go

@@ -7,6 +7,7 @@ import (
 	"fmt"
 	"reflect"
 	"sync"
+	"time"
 
 	"github.com/ava-labs/avalanchego/codec"
 	"github.com/ava-labs/avalanchego/codec/reflectcodec"
@@ -44,23 +45,23 @@ type linearCodec struct {
 
 // New returns a new, concurrency-safe codec; it allow to specify
 // both tagNames and maxSlicelenght
-func New(tagNames []string, maxSliceLen uint32) Codec {
+func New(durangoTime time.Time, tagNames []string, maxSliceLen uint32) Codec {
 	hCodec := &linearCodec{
 		nextTypeID:      0,
 		registeredTypes: bimap.New[uint32, reflect.Type](),
 	}
-	hCodec.Codec = reflectcodec.New(hCodec, tagNames, maxSliceLen)
+	hCodec.Codec = reflectcodec.New(hCodec, tagNames, durangoTime, maxSliceLen)
 	return hCodec
 }
 
 // NewDefault is a convenience constructor; it returns a new codec with reasonable default values
-func NewDefault() Codec {
-	return New([]string{reflectcodec.DefaultTagName}, DefaultMaxSliceLength)
+func NewDefault(durangoTime time.Time) Codec {
+	return New(durangoTime, []string{reflectcodec.DefaultTagName}, DefaultMaxSliceLength)
 }
 
 // NewCustomMaxLength is a convenience constructor; it returns a new codec with custom max length and default tags
-func NewCustomMaxLength(maxSliceLen uint32) Codec {
-	return New([]string{reflectcodec.DefaultTagName}, maxSliceLen)
+func NewCustomMaxLength(durangoTime time.Time, maxSliceLen uint32) Codec {
+	return New(durangoTime, []string{reflectcodec.DefaultTagName}, maxSliceLen)
 }
 
 // Skip some number of type IDs

codec/linearcodec/codec_test.go

@@ -7,23 +7,24 @@ import (
 	"testing"
 
 	"github.com/ava-labs/avalanchego/codec"
+	"github.com/ava-labs/avalanchego/utils/timer/mockable"
 )
 
 func TestVectors(t *testing.T) {
 	for _, test := range codec.Tests {
-		c := NewDefault()
+		c := NewDefault(mockable.MaxTime)
 		test(c, t)
 	}
 }
 
 func TestMultipleTags(t *testing.T) {
 	for _, test := range codec.MultipleTagsTests {
-		c := New([]string{"tag1", "tag2"}, DefaultMaxSliceLength)
+		c := New(mockable.MaxTime, []string{"tag1", "tag2"}, DefaultMaxSliceLength)
 		test(c, t)
 	}
 }
 
 func FuzzStructUnmarshalLinearCodec(f *testing.F) {
-	c := NewDefault()
+	c := NewDefault(mockable.MaxTime)
 	codec.FuzzStructUnmarshal(c, f)
 }

codec/reflectcodec/type_codec.go

@@ -9,6 +9,7 @@ import (
 	"fmt"
 	"math"
 	"reflect"
+	"time"
 
 	"golang.org/x/exp/slices"
 
@@ -72,14 +73,16 @@ type TypeCodec interface {
 //  7. nil slices are marshaled as empty slices
 type genericCodec struct {
 	typer       TypeCodec
+	durangoTime time.Time // Time after which [maxSliceLen] will be ignored
 	maxSliceLen uint32
 	fielder     StructFielder
 }
 
 // New returns a new, concurrency-safe codec
-func New(typer TypeCodec, tagNames []string, maxSliceLen uint32) codec.Codec {
+func New(typer TypeCodec, tagNames []string, durangoTime time.Time, maxSliceLen uint32) codec.Codec {
 	return &genericCodec{
 		typer:       typer,
+		durangoTime: durangoTime,
 		maxSliceLen: maxSliceLen,
 		fielder:     NewStructFielder(tagNames),
 	}
@@ -361,7 +364,14 @@ func (c *genericCodec) marshal(
 		return p.Err
 	case reflect.Slice:
 		numElts := value.Len() // # elements in the slice/array. 0 if this slice is nil.
-		if uint32(numElts) > c.maxSliceLen {
+		if numElts > math.MaxInt32 {
+			return fmt.Errorf("%w; slice length, %d, exceeds maximum length, %d",
+				codec.ErrMaxSliceLenExceeded,
+				numElts,
+				math.MaxInt32,
+			)
+		}
+		if time.Now().Before(c.durangoTime) && uint32(numElts) > c.maxSliceLen {
 			return fmt.Errorf("%w; slice length, %d, exceeds maximum length, %d",
 				codec.ErrMaxSliceLenExceeded,
 				numElts,
@@ -391,19 +401,12 @@ func (c *genericCodec) marshal(
 		}
 		return nil
 	case reflect.Array:
-		numElts := value.Len()
 		if elemKind := value.Type().Kind(); elemKind == reflect.Uint8 {
 			sliceVal := value.Convert(reflect.TypeOf([]byte{}))
 			p.PackFixedBytes(sliceVal.Bytes())
 			return p.Err
 		}
-		if uint32(numElts) > c.maxSliceLen {
-			return fmt.Errorf("%w; array length, %d, exceeds maximum length, %d",
-				codec.ErrMaxSliceLenExceeded,
-				numElts,
-				c.maxSliceLen,
-			)
-		}
+		numElts := value.Len()
 		for i := 0; i < numElts; i++ { // Process each element in the array
 			if err := c.marshal(value.Index(i), p, typeStack); err != nil {
 				return err
@@ -424,7 +427,14 @@ func (c *genericCodec) marshal(
 	case reflect.Map:
 		keys := value.MapKeys()
 		numElts := len(keys)
-		if uint32(numElts) > c.maxSliceLen {
+		if numElts > math.MaxInt32 {
+			return fmt.Errorf("%w; slice length, %d, exceeds maximum length, %d",
+				codec.ErrMaxSliceLenExceeded,
+				numElts,
+				math.MaxInt32,
+			)
+		}
+		if time.Now().Before(c.durangoTime) && uint32(numElts) > c.maxSliceLen {
 			return fmt.Errorf("%w; map length, %d, exceeds maximum length, %d",
 				codec.ErrMaxSliceLenExceeded,
 				numElts,
@@ -586,18 +596,18 @@ func (c *genericCodec) unmarshal(
 		if p.Err != nil {
 			return fmt.Errorf("couldn't unmarshal slice: %w", p.Err)
 		}
-		if numElts32 > c.maxSliceLen {
+		if numElts32 > math.MaxInt32 {
 			return fmt.Errorf("%w; array length, %d, exceeds maximum length, %d",
 				codec.ErrMaxSliceLenExceeded,
 				numElts32,
-				c.maxSliceLen,
+				math.MaxInt32,
 			)
 		}
-		if numElts32 > math.MaxInt32 {
+		if time.Now().Before(c.durangoTime) && numElts32 > c.maxSliceLen {
 			return fmt.Errorf("%w; array length, %d, exceeds maximum length, %d",
 				codec.ErrMaxSliceLenExceeded,
 				numElts32,
-				math.MaxInt32,
+				c.maxSliceLen,
 			)
 		}
 		numElts := int(numElts32)
@@ -694,7 +704,14 @@ func (c *genericCodec) unmarshal(
 		if p.Err != nil {
 			return fmt.Errorf("couldn't unmarshal map: %w", p.Err)
 		}
-		if numElts32 > c.maxSliceLen {
+		if numElts32 > math.MaxInt32 {
+			return fmt.Errorf("%w; map length, %d, exceeds maximum length, %d",
+				codec.ErrMaxSliceLenExceeded,
+				numElts32,
+				math.MaxInt32,
+			)
+		}
+		if time.Now().Before(c.durangoTime) && numElts32 > c.maxSliceLen {
 			return fmt.Errorf("%w; map length, %d, exceeds maximum length, %d",
 				codec.ErrMaxSliceLenExceeded,
 				numElts32,

database/encdb/codec.go

@@ -4,6 +4,8 @@
 package encdb
 
 import (
+	"time"
+
 	"github.com/ava-labs/avalanchego/codec"
 	"github.com/ava-labs/avalanchego/codec/linearcodec"
 )
@@ -13,7 +15,7 @@ const CodecVersion = 0
 var Codec codec.Manager
 
 func init() {
-	lc := linearcodec.NewDefault()
+	lc := linearcodec.NewDefault(time.Time{})
 	Codec = codec.NewDefaultManager()
 
 	if err := Codec.RegisterCodec(CodecVersion, lc); err != nil {

database/linkeddb/codec.go

@@ -5,6 +5,7 @@ package linkeddb
 
 import (
 	"math"
+	"time"
 
 	"github.com/ava-labs/avalanchego/codec"
 	"github.com/ava-labs/avalanchego/codec/linearcodec"
@@ -15,7 +16,7 @@ const CodecVersion = 0
 var Codec codec.Manager
 
 func init() {
-	lc := linearcodec.NewCustomMaxLength(math.MaxUint32)
+	lc := linearcodec.NewDefault(time.Time{})
 	Codec = codec.NewManager(math.MaxInt32)
 
 	if err := Codec.RegisterCodec(CodecVersion, lc); err != nil {

genesis/genesis.go

@@ -552,9 +552,12 @@ func VMGenesis(genesisBytes []byte, vmID ids.ID) (*pchaintxs.Tx, error) {
 }
 
 func AVAXAssetID(avmGenesisBytes []byte) (ids.ID, error) {
-	parser, err := xchaintxs.NewParser([]fxs.Fx{
-		&secp256k1fx.Fx{},
-	})
+	parser, err := xchaintxs.NewParser(
+		time.Time{},
+		[]fxs.Fx{
+			&secp256k1fx.Fx{},
+		},
+	)
 	if err != nil {
 		return ids.Empty, err
 	}

indexer/codec.go

@@ -5,6 +5,7 @@ package indexer
 
 import (
 	"math"
+	"time"
 
 	"github.com/ava-labs/avalanchego/codec"
 	"github.com/ava-labs/avalanchego/codec/linearcodec"
@@ -15,7 +16,7 @@ const CodecVersion = 0
 var Codec codec.Manager
 
 func init() {
-	lc := linearcodec.NewCustomMaxLength(math.MaxUint32)
+	lc := linearcodec.NewDefault(time.Time{})
 	Codec = codec.NewManager(math.MaxInt)
 
 	if err := Codec.RegisterCodec(CodecVersion, lc); err != nil {