[ACP 151] Use current block's P-Chain height as context for verifying state of the inner block #3459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… state of the inner block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Implements ACP 151 to improve UX of PChain and L1 interop for flows defined in ACP-77.
How this works
Passes in current block's P-Chain height into
block.Context'sPChainHeightfield instead of the parent if Etna is activated.How this was tested
Existing test mock expect was updated to reflect new behavior and a new test case for Pre-Etna behavior on the build side was added.
TODO: add testing for pre-etna verify