ACP-77: Include validator capacity into the fee config #3464
+11
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
approved these changes
Oct 11, 2024
marun
approved these changes
Oct 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
StephenButtolph
deleted the
implement-acp-77-cleanup-validator-fee-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Initially,
Capacitywasn't included in the fee config because theCapacityisn't used to calculate the fees... But as we use this config more, it is becoming increasingly annoying to need to pass around a struct and a value.. We could add a second wrapper struct... but I felt like this was the cleanest option right now.How this works
Moves the capacity var into the config.
How this was tested
N/A