E2E tests #26
Merged
E2E tests #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 23 commits
August 31, 2023 05:01
|
LGTM, going to refresh reviews |
minghinmatthewlam
requested review from
geoff-vball,
cam-schultz,
michaelkaplan13 and
gwen917
geoff-vball
reviewed
Sep 21, 2023
messages/teleporter/message.go
Outdated
| func UnpackMessageReceivedResult(result []byte) (bool, error) { | ||
| var success bool | ||
| err := EVMTeleporterContractABI.UnpackIntoInterface(&success, "messageReceived", result) | ||
| return success, err | ||
| } | ||
|
|
||
| // PackSendCrossChainMessageEvent packs the SendCrossChainMessage event type. PackEvent is documented as not supporting struct types, so this should be used | ||
| // with caution. Here, we only use it for testing purposes. In a real setting, the Teleporter contract should pack the event. |
There was a problem hiding this comment.
Can we make this warning a little more obvious? Maybes start one line of the comment with "CAUTION". I would totally miss this most of the time.
There was a problem hiding this comment.
Good call, clarified that. I also thought about moving it to package tests, but that unfortunately creates an import cycle. If we decide to move these Teleporter packing/unpacking utils to teleporter, we can spend more energy putting up better guardrails, but IMO a more explicit comment is sufficient for now.
geoff-vball
previously approved these changes
Sep 22, 2023
cam-schultz
previously approved these changes
Sep 25, 2023
cam-schultz
dismissed stale reviews from geoff-vball and themself
via
a4d2cf5
geoff-vball
approved these changes
Sep 25, 2023
cam-schultz
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Provides an e2e test that makes sure the relayer is running properly from start up, subscribing, and delivering the message to destination chain and address. Fixes #15
How this works
sendWarpMessagewith a Teleporter message payloadThis can be extended for other future message protocols we support.
How this was tested
CI, unit tests, locally
How is this documented
README