Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use docker build path context #50

Merged
merged 1 commit into from
Sep 27, 2023
Merged

use docker build path context #50

merged 1 commit into from
Sep 27, 2023

Conversation

minghinmatthewlam
Copy link

Why this should be merged

Release action for publish docker image is failing, this hopes to address and fix.

How this works

for build-push-action docs, specifies we use git context without the checkout action, or if we use checkout action we should pass in path context. So this PR is adding the path context since we do use checkout action.

How this was tested

n/a

How is this documented

n/a

@michaelkaplan13
Copy link
Collaborator

Given that we don't modify any files after the checkout step, it seems like the recommended use here would be to not have the separate checkout step at all, and just use the default git context. I could be missing some context though.

@minghinmatthewlam
Copy link
Author

in the build-push-actions docs https://github.com/docker/build-push-action, by default it doesn't use the checkout action, and wouldn't need the additionial context: . , but think this is easier to read and more inline with the other workflows that use the checkout option. Discussed offline, will leave in this format.

@minghinmatthewlam minghinmatthewlam merged commit fc35ffa into main Sep 27, 2023
8 checks passed
@michaelkaplan13 michaelkaplan13 deleted the release-context branch September 27, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants