use upstream instruction sets #657
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
changed the title
darioush
changed the title
darioush
commented
Sep 24, 2024
|
|
||
| type StateDB = vm.StateDB | ||
|
|
||
| func TestStatefulPrecompile(t *testing.T) { |
There was a problem hiding this comment.
this test has to move out of core/vm, since we want to get the statedb with the hook configured.
darioush
commented
Sep 24, 2024
Comment on lines
+23
to
+29
| NativeAssetBalanceAddr = vm.NativeAssetBalanceAddr | ||
| PackNativeAssetBalanceInput = vm.PackNativeAssetBalanceInput | ||
| NativeAssetCallAddr = vm.NativeAssetCallAddr | ||
| PackNativeAssetCallInput = vm.PackNativeAssetCallInput | ||
| ) | ||
|
|
||
| type StateDB = vm.StateDB |
There was a problem hiding this comment.
these are just temporary, we can do the replace in the text below before merging.
left the text mostly as is in case we also want to move these out of the vm package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
How this was tested