Manually tracked ips config for signature-aggregator #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iansuvak
requested review from
richardpringle,
geoff-vball,
bernard-avalabs,
michaelkaplan13,
cam-schultz and
mdelle1
bernard-avalabs
approved these changes
Feb 28, 2025
geoff-vball
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This is already possible for the relayer but not for sig-agg. Allowing this would enable folks running on private networks and without reachable public ips set on their validators to still test the L1 conversion process.
How this works
Exposes the same config available in relayer.
How this was tested
E2E
How is this documented
Added the doc reference fixed the link. Should follow up with a docs PR that elaborates on the reference here and somehow better merges/references shared config between relayer and signature aggregator