fix: run flaky upstream tests sequentially #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are fewer of them so they'll fail quickly and allow the CI run to just be restarted.
ARR4N
requested review from
a team,
darioush,
ceyonur and
michaelkaplan13
and removed request for
a team
darioush
reviewed
Sep 12, 2024
| run: go test -short $(go list ./... | grep -Pv 'go-ethereum/(accounts/keystore|eth/downloader|miner)$') | ||
| run: | # Upstream flakes are race conditions exacerbated by concurrent tests | ||
| FLAKY_REGEX='go-ethereum/(eth|accounts/keystore|eth/downloader|miner)$'; | ||
| go list ./... | grep -P "${FLAKY_REGEX}" | xargs -n 1 go test -short; |
There was a problem hiding this comment.
just a heads up that -P isn't supported on mac
There was a problem hiding this comment.
Thanks. I forgot because I very quickly installed GNU tools when I got one!
When we extend CI testing beyond this basic one we should discuss the extent to which we want to run upstream tests in different environments, given that they already do it extensively.
darioush
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Some upstream tests are flaky and had been disabled. Others required multiple CI runs until green. This (should) address the problem while allowing all tests to be run.
Fixes #10
How this works
The flakes are race conditions, exacerbated by tests being run concurrently (higher load). The flaky tests are excluded from the primary run and are instead run sequentially; this is done first so they can fail quickly and allow a CI re-run without waiting ~5 minutes for the regular tests to pass.
How this was tested
CI trial and error.