add p2p handler for acp-118 sig request #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
commented
Jul 30, 2024
ceyonur
reviewed
Jul 30, 2024
darioush
commented
Jul 30, 2024
michaelkaplan13
previously approved these changes
Jul 30, 2024
ceyonur
reviewed
Aug 1, 2024
ceyonur
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
#1259
How this works
Adds support for ACP-118 message types.
Assumes that 32 bytes messages should be interpreted as a block hash
This PR mostly adopts the existing code to the new handlers & protos as defined in ACP-118.
How this was tested
CI
How is this documented
N/A