fix: wrong overall coverage report dependencies #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are using |
cuinixam
force-pushed
the
fix_coverage_deps
branch
from
504d4b6 to
f18b209
Compare
xxthunder
reviewed
Dec 4, 2023
xxthunder
reviewed
Dec 4, 2023
cmake/common.cmake
Outdated
| @@ -318,6 +319,8 @@ macro(_spl_add_test_suite PROD_SRC TEST_SOURCES) | |||
| ) | |||
|
|
|||
| # Create coverage report | |||
| set(GLOBAL_COMPONENTS_COVERAGE_JSON_LIST "${GLOBAL_COMPONENTS_COVERAGE_JSON_LIST};${CMAKE_CURRENT_BINARY_DIR}/coverage.json" CACHE INTERNAL "List of all coverage.json files") | |||
|
|
|||
| set(COV_OUT_JSON coverage.json) | |||
There was a problem hiding this comment.
We should use this variable name everywhere instead of "coverage.json".
xxthunder
reviewed
Dec 4, 2023
xxthunder
reviewed
Dec 4, 2023
cuinixam
force-pushed
the
fix_coverage_deps
branch
from
d576f7a to
b83ba06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.