Merge pull request #31 from ZedRover/main

replace finish with close
avik-pal · Mar 23, 2024 · bfcf49e · bfcf49e
2 parents 1c76c18 + 7d1c794
commit bfcf49e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/ext/WandbFluxTrainingExt.jl b/ext/WandbFluxTrainingExt.jl
@@ -13,7 +13,7 @@ function Base.close(wa::Wandb.WandbBackend, args...; kwargs...)
   return close(wa.logger, args...; kwargs...)
 end
 
-for func in (:log, :update_config!, :finish, :save, :get_config)
+for func in (:log, :update_config!, :close, :save, :get_config)
   @eval begin
     function Wandb.$(func)(wa::Wandb.WandbBackend, args...; kwargs...)
       return Wandb.$(func)(wa.logger, args...; kwargs...)

diff --git a/ext/WandbMPIExt.jl b/ext/WandbMPIExt.jl
@@ -57,7 +57,7 @@ for func in (:log, :close)
   end
 end
 
-for func in (:increment_step!, :finish, :save)
+for func in (:increment_step!, :close, :save)
   @eval begin
     function Wandb.$(func)(wa::WandbLoggerMPI, args...; kwargs...)
       return Wandb.$(func)(wa.logger, args...; kwargs...)

diff --git a/src/main.jl b/src/main.jl
@@ -83,7 +83,7 @@ end
 Terminate the current run. For more details checkout `wandb.finish` (or
 `? Wandb.wandb.finish` in the Julia REPL).
 """
-Base.close(lg::WandbLogger; kwargs...) = lg.wrun.finish(; kwargs...)
+Base.close(lg::WandbLogger; kwargs...) = lg.wrun.close(; kwargs...)
 
 """
     save(lg::WandbLogger, args...; kwargs...)