Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: radio field accessibility #3666

Merged
merged 2 commits into from
Feb 14, 2025
Merged

fix: radio field accessibility #3666

merged 2 commits into from
Feb 14, 2025

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Feb 14, 2025

Description

Fixes #3659
Fixes #3649

Fix radio field accessibility by correctly associating the label with its corresponding checkbox. Also ensures that the radio field selects the default value if given on actions.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added the Fix label Feb 14, 2025
Copy link

codeclimate bot commented Feb 14, 2025

Code Climate has analyzed commit 87e0dd2 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob force-pushed the fix/radio_field_accessibility branch from c9e9277 to 8609c42 Compare February 14, 2025 08:51
@Paul-Bob Paul-Bob closed this Feb 14, 2025
@Paul-Bob Paul-Bob force-pushed the fix/radio_field_accessibility branch from 8609c42 to 1c5ae81 Compare February 14, 2025 08:52
@Paul-Bob Paul-Bob reopened this Feb 14, 2025
@Paul-Bob Paul-Bob merged commit a9eb706 into main Feb 14, 2025
20 checks passed
@Paul-Bob Paul-Bob deleted the fix/radio_field_accessibility branch February 14, 2025 09:15
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't set default value for a radio (in actions) click radio label to select value
1 participant