Skip to content

Commit

Permalink
pylint-3 removal
Browse files Browse the repository at this point in the history
Avocado is using pylint-3 instead of default pylint. This is a leftover
from the time when avocado supported python2. Unfortunately, the
pylint-3 has slightly different behaviour than pylint, therefore we need
to update it to have more accurate testing. Lets use python3 -m pylint

Signed-off-by: Jan Richter <[email protected]>
  • Loading branch information
richtja committed Jul 10, 2024
1 parent 8620182 commit cc49048
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 1 addition & 3 deletions selftests/lint.sh
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
#!/bin/sh -e
echo "** Running lint..."

PYLINT=$(which pylint-3 2>/dev/null || which pylint)

# Those are files from our main packages, we should follow the .pylintrc file with all
# enabled by default. Some are disabled, we are working to reduce this list.
FILES=$(git ls-files '*.py')
${PYLINT} ${PYLINT_OPTIONS} ${FILES}
python3 -m pylint ${PYLINT_OPTIONS} ${FILES}
4 changes: 1 addition & 3 deletions selftests/spell.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
#!/bin/sh -e
echo "** Running spell check..."

PYLINT=$(which pylint-3 2>/dev/null || which pylint)

${PYLINT} -j 1 --errors-only --disable=all --enable=spelling --spelling-dict=en_US --spelling-private-dict-file=spell.ignore *
python3 -m pylint -j 1 --disable=all --enable=spelling --spelling-dict=en_US --spelling-private-dict-file=spell.ignore *

0 comments on commit cc49048

Please sign in to comment.