Test file import versus system module #5716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The legacy loader system could pass actual class objects instead of their names. This is no longer the case with the resolver, so the class name will always be a string. Signed-off-by: Cleber Rosa <[email protected]>
Before nrunner, all test conditions (including errors) were "communicated" by means of specialized class inheriting from avocado.core.test.Test. With nrunner, the conditions are communicated using messages, and that is true for errors. The "avocado-instrumented" runner already protects against exceptions while trying to load/import test modules, so this extra handling is completely unnecessary. Signed-off-by: Cleber Rosa <[email protected]>
The load_test() function simply won't work without the path for the Python module to be imported. Instead of failing cryptically when trying to do `os.path.basename(test_path)` with test_path being None, let's flag that situation and report an error early. Signed-off-by: Cleber Rosa <[email protected]>
If we fail to import the module we want, and find the class we want, let's raise a clear exception that will be given to users. Signed-off-by: Cleber Rosa <[email protected]>
The `sys.path.insert()` strategy being used up to this point is actually ineffective when the same module name exists elsewhere. With this change, explicit path of the Python file that contains the test is used to describe what module to load. Fixes: avocado-framework#5686 Signed-off-by: Cleber Rosa <[email protected]>
richtja
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Hi @clebergnu, thank you for this loader clean up, it LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a condition on the test loader for avocado-instrumented, in which it can fail to load module from correct path.
More on #5686