Revert Avocado Instrumented Tests Log Message Format to 92LTS Version #5732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clebergnu
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Looks right to me:
[stdlog] 2023-07-17 20:35:22,585 test L0209 INFO | Avocado-VT '100.1-201-ge20d6', Branch 'master', SHA1 'e20d6f47c2198f423bbc8f420b2775e404322416'
[stdlog] 2023-07-17 20:35:22,585 utils L0161 DEBUG| Test parameters:
[stdlog] 2023-07-17 20:35:22,585 utils L0165 DEBUG| auto_cpu_model = yes
...
|
Hello @richtja , in debug.log, now it is fixed: But in full.log, now it is still as before: Could we make full.log fixed too? |
Sure, I will do that. Thank you for your review. |
This commit addresses compatibility concerns by reverting the log message format of Avocado instrumented tests back to the 92LTS (Long-Term Support) version. By doing so, we ensure compatibility with the upcoming LTS version. Reference: avocado-framework#5721 Signed-off-by: Jan Richter <[email protected]>
We use to re-log messages when avocado receives them from runner. For this feature we supported the `log_message` attribute which split the log message into two part, one with the real log and second log with metadata. Unfortunately, this solution has an issue. When avocado re-logs the message, it loses the logging metadata and logs shows wrong lines and modules. This commit removes this mechanism and keep the creation of log messages only to runners. before this change: 2023-07-25 10:33:52,781 messages L0378 INFO | 1-examples/tests/passtest.py:PassTest.test: INIT 1-examples/tests/passtest.py:PassTest.test 2023-07-25 10:33:52,781 messages L0378 DEBUG| 1-examples/tests/passtest.py:PassTest.test: PARAMS (key=timeout, path=*, default=None) => None after this change: 1-examples/tests/passtest.py:PassTest.test: 2023-07-25 14:00:50,323 test L0313 INFO | INIT 1-examples/tests/passtest.py:PassTest.test 1-examples/tests/passtest.py:PassTest.test: 2023-07-25 14:00:50,324 parameters L0141 DEBUG| PARAMS (key=timeout, path=*, default=None) => None Signed-off-by: Jan Richter <[email protected]>
|
Hi @dzhengfy and @clebergnu I updated the PR based on your reviews. I had to the change to how we propagate messages from runners to full.log. Please take a look. Thank you. |
|
@richtja , Test with master branch, and it looks fine to me and most consistent to the 92lts' format. Thanks. |
dzhengfy
approved these changes
Jul 27, 2023
|
@clebergnu Could you help double review it? |
|
/packit copr-build |
richtja
added a commit
to richtja/avocado
that referenced
this pull request
Dec 8, 2023
In avocado-framework#5665 we introduced the logging stream name in test logs, this added more possibilities for user how to post-process test logs. Unfortunately, this change also hided information about modules where the log has been created. This issue has been solved in avocado-framework#5732. This commit connects those two solutions by storing stream and module names. Referencei: avocado-framework#5665 avocado-framework#5732 Signed-off-by: Jan Richter <[email protected]>
richtja
added a commit
to richtja/avocado
that referenced
this pull request
Dec 13, 2023
In avocado-framework#5665 we introduced the logging stream name in test logs, this added more possibilities for user how to post-process test logs. Unfortunately, this change also hided information about modules where the log has been created. This issue has been solved in avocado-framework#5732. This commit connects those two solutions by storing stream and module names. Referencei: avocado-framework#5665 avocado-framework#5732 Signed-off-by: Jan Richter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses compatibility concerns by reverting the log message format of Avocado instrumented tests back to the 92LTS (Long-Term Support) version. By doing so, we ensure compatibility with the upcoming LTS version.
Reference: #5721
Signed-off-by: Jan Richter [email protected]