Avocado Coverage.py updates #5944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 30, 2024
This commit simplifies the usage of coverage.py without change of its behaviour. With these changes, it will be easier for users to set up avocado for gathering test coverage data. Reference: avocado-framework#5919 Signed-off-by: Jan Richter <[email protected]>
This commit brings coverage.py feature to python unittest runner. After this change, you can run coverage.py with avocado for avocado-instrumented and python unittest types. Reference: avocado-framework#4957 Signed-off-by: Jan Richter <[email protected]>
The avocado was using `selftests/run` script for running coverage tests. This script uses python unittests module instead of avocado, which has few disadvantages. The main is that running the `selftests/run` differs from running `check.py`, therefore the coverage report hasn't represented the actual state. After the latest changes in ea0e23d and 4100cc2 it is possible to run avocado's main selftests entry point `check.py` with the coverage.py. With such change, the running coverage diagnose will use the same process as our selftests, therefore the report will be more precise. Reference: avocado-framework#4992 Signed-off-by: Jan Richter <[email protected]>
After the changes in bf58ffc the only used selftests entry point is `check.py`, therefore we can remove the `selftests/run` script from avocado repo. Reference: avocado-framework#4992 Signed-off-by: Jan Richter <[email protected]>
|
How would you feel about back porting this to the LTS? We would appreciate it, and we can go fully avocado |
Hi @arif-ali this was created based on your comments in #5610 (comment), can you please try it out in your environment? If it works, I don't see a problem with the backport to LTS. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some simplification of caverage.py usage with avocado. And fixes avocado issue related to this topic: