Runnable: fix job/suite config use and runnable identifier #5977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 94584fc ("Runnable: do not ignore the configuration passed from recipes"). That change, because of the fact that every runnable uses "runner.identifier_format", erroneously assumed that every configuration should be passed to the runnables. In fact, it was decided long ago, and implemented after that, that only the configuration that is used by runnables should be set on them. Now, because "runner.indentifier_format" is used by all, this needs to be taken into account. In the near future, we may revisit the idea of "runner.indentifier_format" being handled by the runnable as a configuration item, and be transformed into a primary parameter of the runnables. Reference: avocado-framework#5964 Signed-off-by: Cleber Rosa <[email protected]>
The setting of configuration into runnables is currently being done at the time where a runnable will be run (at the "nrunner" suite runner plugin). But, there are situations, such as when using the Job API, that this is too late or not effective. This change moves the setting of the configuration to the suite, which is based on the job configuration, and thus already has all the information needed to set the final version of the configuration. Fixes: avocado-framework#5963 Signed-off-by: Cleber Rosa <[email protected]>
A runnable will have its configuration updated by the suite (and job) configuration at suite creation time. This configuration should be used, and not the one at the time the Runnable was crated, to set the runnable identifier. Signed-off-by: Cleber Rosa <[email protected]>
clebergnu
force-pushed
the
runnable_job_suite_config_identifier
branch
from
c34cc91
to
5430018
Compare
The most common scenario is the runnable having its identifier format after its URI. When that's the case, there's no need to build the arguments to the formatting string and performing the string format itself. Signed-off-by: Cleber Rosa <[email protected]>
clebergnu
force-pushed
the
runnable_job_suite_config_identifier
branch
from
5430018
to
3a73b30
Compare
clebergnu
added
bug
customer:Passt
richtja
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a few different issues that in the end, result in the failure to set and apply a Runnable's identifier.
More specifically this: