Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards compatibility for kernel utils module #5999

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

richtja
Copy link
Contributor

@richtja richtja commented Aug 12, 2024

This is a fix of kerne utils compatibility issue with setuptools=>70 which has been introduced in df6b1da.

Reference: #5988

This is a fix of kerne utils compatibility issue with setuptools=>70
which has been introduced in df6b1da.

Reference: avocado-framework#5988
Signed-off-by: Jan Richter <[email protected]>
@richtja richtja added the bug label Aug 12, 2024
@richtja richtja self-assigned this Aug 12, 2024
@richtja richtja linked an issue Aug 12, 2024 that may be closed by this pull request
@richtja
Copy link
Contributor Author

richtja commented Aug 19, 2024

Hi @clebergnu and @harvey0100, gentle ping here.

Copy link
Contributor

@clebergnu clebergnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:

avocado]# pip install . 
Processing /root/src/avocado
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Requirement already satisfied: setuptools in /usr/lib/python3.12/site-packages (from avocado-framework==106.0) (69.0.3)
Building wheels for collected packages: avocado-framework
  Building wheel for avocado-framework (pyproject.toml) ... done
  Created wheel for avocado-framework: filename=avocado_framework-106.0-py3-none-any.whl size=449555 sha256=e3d3b8dd964f8f1154eb6aa25f103014bab6e496681e2030dbddfbb3fafe515a
  Stored in directory: /tmp/pip-ephem-wheel-cache-r5d_tj57/wheels/fd/07/08/6c0eba8c6ebbb2d42c259865dd7cb0d04641f2914d999dbd02
Successfully built avocado-framework
Installing collected packages: avocado-framework
  Attempting uninstall: avocado-framework
    Found existing installation: avocado-framework 106.0
    Uninstalling avocado-framework-106.0:
      Successfully uninstalled avocado-framework-106.0
Successfully installed avocado-framework-106.0
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
[root@a09a6f522775 avocado]# python3 -c 'import avocado.utils.kernel'
[root@a09a6f522775 avocado]# git show 
commit 58738b61a8bd6af542ff82a2ccccb49551c48c1b (HEAD -> packaging_import_fix, richtja/packaging_import_fix)

Thanks!

@clebergnu clebergnu merged commit 20053f6 into avocado-framework:master Aug 26, 2024
57 of 58 checks passed
@richtja richtja deleted the packaging_import_fix branch August 26, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Usage of external dependency "packaging" in avocado/utils/kernel.py
3 participants