Avocado: use avocado-static-checks #6026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtja
requested changes
Sep 13, 2024
There was a problem hiding this comment.
Hi @clebergnu, the overall changes LGTM, but IIUIC avocado uses submodules now, therefore we need to update the contribution guide, because the Git workflow, will be different from now.
This enables the bare minimum of the avocado-static-checks usage, adds the submodule switches the "isort" check, one of the most simplistic, to the one provided by the avocado-static-checks repo. Fixes: avocado-framework#5991 Signed-off-by: Cleber Rosa <[email protected]>
This replaces another one of the in-tree check scripts with the one provided by avocado-static-checks. Fixes: avocado-framework#5989 Signed-off-by: Cleber Rosa <[email protected]>
This switches to the script provided by the avocado-static-checks repo, while using the local pylintrc configuration (set through the use of "avocado-static-checks.conf". In the near future, at least the "avocado/utils" directory needs to made compliant with the standard pylint configuration provided by avocado-static-checks, so that code can be easily moved to autils. Fixes: avocado-framework#5990 Signed-off-by: Cleber Rosa <[email protected]>
clebergnu
force-pushed
the
avocado_static_checks
branch
from
ab20361
to
41edcce
Compare
Good point @richtja ! I've sent an update. Thanks for the review. |
richtja
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces the use of the "avocado-static-checks" repo as a submodule, in lieu of the in-tree scripts being used.
The idea is to have a uniform code style across avocado and other projects such as avocado-vt and autils.