Improve handling of non-region names in getNamedRegions and add related test #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Excel files contain sheet names for veryHidden sheets that do not have any sheet content. Such sheets have an empty r:id. Their sheet names have to be skipped because otherwise there will be a misalignment between sheet names and sheet indeces.
…ed test Excel names don't need to point to regions, they may point to constants, such as 10000, or other names. Currently getNamedRegions can skip these, causing the sheets and regions attributes not to line up with the names. This patch just sets the sheet and region to "" (empty string) for the names like this.
Codecov Report
@@ Coverage Diff @@
## master #474 +/- ##
==========================================
+ Coverage 60.23% 60.32% +0.08%
==========================================
Files 30 30
Lines 7142 7155 +13
==========================================
+ Hits 4302 4316 +14
+ Misses 2840 2839 -1
Continue to review full report at Codecov.
|
|
I implemented your PR in my new fork of the repository https://github.com/ycphs/openxlsx |
david-f1976
pushed a commit
to david-f1976/openxlsx
that referenced
this pull request
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excel names don't need to point to regions, they may point to constants, such as 10000, or other names.
Currently getNamedRegions can skip these, causing the sheets and regions attributes not to line up with the names.
This patch just sets the sheet and region to "" (empty string) for the names like this.