Allow any object to override awesome print via #ai #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug fix: Duplicate options before mutating it ----------------------------------------------------------- On branch master - Wed 12 Apr 2017 15:18:51 PDT by matrinox <[email protected]>
Only the top layer will wrap code in pre tags (fixed) The current indentation amount is passed in to the inspector so that new ones will maintain the same indentation ----------------------------------------------------------- On branch master - Mon 17 Apr 2017 17:40:14 PDT by matrinox <[email protected]>
|
I quite like this change but I would like to hear other opinions on that. In any case, it would be nice to also have this documented. |
|
@thiagofm How do you guys do documentation? Let me know and I'll submit it as part of this PR |
|
I'm happy with most of the code except one: the I'm not too happy with it so I would love to hear how you guys would solve it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: Duplicate options before mutating it
Changes:
inspector.awesome(x)are replaced withx.ai(@options)I noticed that ai calls
inspector.awesomeso I figured we can change it#aiwithout breaking much. I know this way is less efficient but for debugging, it's not going to be a huge concern.