Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(BREAKING CHANGE) Fix the output of menubar.utils.parse_desktop_file().Actions to be locallized #3710

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SkyyySi
Copy link

@SkyyySi SkyyySi commented Sep 30, 2022

This PR will change the behavior of menubar.utils.parse_desktop_file() to alter its Actions key. Before, it returned a list of strings that were the identifiers of each available action. Now, it will instead contain the Name, Exec and Icon keys for each action, as described here (depending on which keys were set by the .desktop-file).

@Elv13
Copy link
Member

Elv13 commented Oct 1, 2022

Hi,

Can we use a non-conflicting name and document it exists? Breaking the API for this doesn't sound like something we can merge. We work very hard to maintain config compatibility across releases, even if that means being bug-compatible. For bug level compatibility, we have something called "API levels", which allows to opt-in to behavior changes, but that's not well suited for this change. A much more labor intensive solution would be to replace those APIs with something which actually comply this the specs. This means gears.desktop/gears.xdg_menu/gears.icon_theme (and they could use the GDK APIs rather than hardcode some Lua). However, that's a very large project, and renaming to something like actions_table is a one-liner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants