Imagebox: add proper svg resizing #3802
Conversation
|
facepalm I'll fix the formatting thing (thanks github addon for randomly opening the PR lol) |
Crylia
force-pushed
the
imagebox_resize_svg_fix
branch
from
9ef9cdc
to
00a8dbc
Compare
Codecov Report
@@ Coverage Diff @@
## master #3802 +/- ##
==========================================
+ Coverage 90.99% 91.02% +0.02%
==========================================
Files 900 901 +1
Lines 57502 57770 +268
==========================================
+ Hits 52325 52586 +261
- Misses 5177 5184 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Crylia
force-pushed
the
imagebox_resize_svg_fix
branch
from
00a8dbc
to
2e1abbd
Compare
| cr:scale(aspects.w, aspects.h) | ||
| if self._private.handle then | ||
| RsvgRect = Rsvg.Rectangle {x = 0, y = 0, width = w*aspects.w, height = h*aspects.h } | ||
| svg_surf = cairo.ImageSurface(cairo.Format.ARGB32, w*aspects.w, h*aspects.h) |
There was a problem hiding this comment.
the stacktrace from the failed test actually pointing to this line, but anyway you got the idea :)
There was a problem hiding this comment.
you marked thread as resolved but test is still failing on this line: https://github.com/awesomeWM/awesome/actions/runs/6042238743/job/16477140356?pr=3802
|
@Crylia apology for the long delay. I wasn't paying attention much to all PRs lately. Can you rebase this so the CI can run? |
|
@Elv13 i've re-opened it to re-run - it should merge without manual rebase |
| cr:scale(aspects.w, aspects.h) | ||
| if self._private.handle then | ||
| RsvgRect = Rsvg.Rectangle {x = 0, y = 0, width = w*aspects.w, height = h*aspects.h } | ||
| svg_surf = cairo.ImageSurface(cairo.Format.ARGB32, w*aspects.w, h*aspects.h) |
There was a problem hiding this comment.
you marked thread as resolved but test is still failing on this line: https://github.com/awesomeWM/awesome/actions/runs/6042238743/job/16477140356?pr=3802
|
also aside from failing test, code-style check is also not passing: https://github.com/awesomeWM/awesome/actions/runs/6042238743/job/16477141387?pr=3802 |
|
Moved to #3881 because I don't have write access to this PR |
This is part one of a small fix for imagebox. This PR is so imagebox correctly resized SVG's, previously it was just rendered by cairo (which worked fine) but for the svg to be properly recolored and rendered the Rsvg object needs to know about its future size, thats why I had to switch to render_document (its what the docs recommend to use anyway) which now takes an extra RsvgRect argument which is a simple stuct with its w/h and x/y(not needed) information
I also added seperate logic to scale the cairo surface. This was needed because the original scale would also automatically scale the SVG again, instead It now scales the rect, and the temporary surface (I needed a new one with the new size, else the original wouldn't fit the resized SVG anymore)