Added gears.string.psplit function to support patterns #3839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you need to add new unit tests for newly-added functionality |
|
(in spec/gears/string_spec.lua) |
actionless
requested changes
Aug 14, 2023
Codecov Report
@@ Coverage Diff @@
## master #3839 +/- ##
==========================================
- Coverage 91.03% 91.01% -0.02%
==========================================
Files 901 901
Lines 57540 57566 +26
==========================================
+ Hits 52380 52396 +16
- Misses 5160 5170 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
actionless
approved these changes
Aug 14, 2023
|
@actionless there are two workflows haven't been passed. Should I do something with them to fix? |
Aire-One
approved these changes
Aug 14, 2023
The luajit error was from a flaky test. I restarted the CI and it's green now. The fixed-lgi-lua5.2 is a luacheck warning: That's a new check for this warning that they added recently, lunarmodules/luacheck#94. It needs to be taken care of first. |
actionless
added a commit
to actionless/awesome
that referenced
this pull request
Aug 15, 2023
Piterden
changed the title
Elv13
pushed a commit
that referenced
this pull request
Aug 17, 2023
awesome-robot
added a commit
to awesomeWM/apidoc
that referenced
this pull request
Aug 17, 2023
Last commit message: style(awful: permissions): luacheck updated (awesomeWM/awesome#3839 (comment)) (#3840) Commits: awesomeWM/awesome@d36e132...28381d2 Build URL: https://github.com/awesomeWM/awesome/actions/runs/5893957619
awesome-robot
added a commit
to awesomeWM/apidoc
that referenced
this pull request
Aug 17, 2023
Last commit message: style(awful: permissions): luacheck updated (awesomeWM/awesome#3839 (comment)) (#3840) Commits: awesomeWM/awesome@d36e132...28381d2 Build URL: https://github.com/awesomeWM/awesome/actions/runs/5893957619
awesome-robot
added a commit
to awesomeWM/apidoc
that referenced
this pull request
Aug 17, 2023
Last commit message: style(awful: permissions): luacheck updated (awesomeWM/awesome#3839 (comment)) (#3840) Commits: awesomeWM/awesome@d36e132...28381d2 Build URL: https://github.com/awesomeWM/awesome/actions/runs/5893957619 Ref: awesomeWM/awesome#3839
UPD tree
|
@Aire-One excuse me for a long delay. Done! |
Aire-One
approved these changes
Nov 10, 2023
actionless
approved these changes
Nov 11, 2023
|
What should I do to fix checks passing? |
Elv13
approved these changes
Nov 19, 2023
|
I squashed the commits, this should solve the problem which was preventing this from auto-merging: |
duxedo
pushed a commit
to duxedo/awesome
that referenced
this pull request
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will support strings with more than one char length and regex patterns. Also there's no need for additional checks for start and end of a string anymore.