Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(permissions: geometry): allow geometry change for non-floating clients if it was requested by awesome's own fullscreen and maximize handlers (fixes: #3844, #3834) #3845

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

actionless
Copy link
Member

No description provided.

…ients if it was requested by awesome's own fullscreen and maximize handlers (fixes: awesomeWM#3844, awesomeWM#3834)
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #3845 (73fad77) into master (d36e132) will increase coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3845      +/-   ##
==========================================
+ Coverage   91.00%   91.02%   +0.01%     
==========================================
  Files         901      901              
  Lines       57532    57536       +4     
==========================================
+ Hits        52358    52372      +14     
+ Misses       5174     5164      -10     
Flag Coverage Δ
gcov 91.02% <100.00%> (+0.01%) ⬆️
luacov 93.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
lib/awful/permissions/init.lua 87.62% <100.00%> (+0.45%) ⬆️

... and 2 files with indirect coverage changes

@Pikabyte
Copy link

I figured I'd add here as well that I can confirm this fixes #3844

@actionless
Copy link
Member Author

thanks for checking! @Pikabyte

Copy link
Member

@Aire-One Aire-One left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Elv13 Elv13 merged commit cd7cb0e into awesomeWM:master Aug 30, 2023
10 checks passed
@actionless actionless deleted the fix-geom-permission branch August 31, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants