Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

menubar.menu_gen: add category other #3892

Closed
wants to merge 1 commit into from
Closed

menubar.menu_gen: add category other #3892

wants to merge 1 commit into from

Conversation

HoNamDuong
Copy link
Contributor

Add other key to menubar.menu_gen.all_categories for apps that don't have Categories= key in .desktop file.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e6f5c79) 91.22% compared to head (96d64b7) 91.22%.

❗ Current head 96d64b7 differs from pull request most recent head 2cd1ad0. Consider uploading reports for the commit 2cd1ad0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3892   +/-   ##
=======================================
  Coverage   91.22%   91.22%           
=======================================
  Files         927      927           
  Lines       59493    59496    +3     
=======================================
+ Hits        54275    54278    +3     
  Misses       5218     5218           
Flag Coverage Δ
gcov 91.22% <75.00%> (+<0.01%) ⬆️
luacov 93.88% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/menubar/menu_gen.lua 98.64% <75.00%> (-1.36%) ⬇️

... and 1 file with indirect coverage changes

@HoNamDuong HoNamDuong closed this Apr 3, 2024
@HoNamDuong HoNamDuong deleted the menubar_menu_gen branch April 3, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants