-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dismiss the notification without triggering default action on right-click #3906
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for looking into this!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3906 +/- ##
=======================================
Coverage 91.27% 91.27%
=======================================
Files 935 935
Lines 60129 60130 +1
=======================================
+ Hits 54880 54883 +3
+ Misses 5249 5247 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Bump, could this be merged if it's approved by everyone? There is currently no easy way to dismiss notifs without the notifying app getting focused. |
Thanks for this. Sorry for the delay, I didn't have time for Awesome over the last year and built a huge backlog of things to look at. |
@Elv13 no worries, thank you very much for the continued work! |
This is an improvement to the problem presented by @BarbUk 's comment here: #3863 (comment)
On right click, the notification dismisses without triggering the default action. On left click, behavior is the same as until now.