Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismiss the notification without triggering default action on right-click #3906

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

danimateo
Copy link
Contributor

This is an improvement to the problem presented by @BarbUk 's comment here: #3863 (comment)

On right click, the notification dismisses without triggering the default action. On left click, behavior is the same as until now.

Copy link
Member

@actionless actionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for looking into this!

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.27%. Comparing base (8b1f895) to head (01b0652).
Report is 10 commits behind head on master.

Files Patch % Lines
lib/naughty/layout/box.lua 50.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3906   +/-   ##
=======================================
  Coverage   91.27%   91.27%           
=======================================
  Files         935      935           
  Lines       60129    60130    +1     
=======================================
+ Hits        54880    54883    +3     
+ Misses       5249     5247    -2     
Flag Coverage Δ
gcov 91.27% <50.00%> (+<0.01%) ⬆️
luacov 93.90% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/naughty/layout/box.lua 94.19% <50.00%> (+0.03%) ⬆️

... and 2 files with indirect coverage changes

@wereii
Copy link

wereii commented May 9, 2024

Bump, could this be merged if it's approved by everyone? There is currently no easy way to dismiss notifs without the notifying app getting focused.

@Elv13 Elv13 merged commit a35fced into awesomeWM:master Aug 27, 2024
10 of 11 checks passed
@Elv13
Copy link
Member

Elv13 commented Aug 27, 2024

Thanks for this. Sorry for the delay, I didn't have time for Awesome over the last year and built a huge backlog of things to look at.

@wereii
Copy link

wereii commented Aug 27, 2024

@Elv13 no worries, thank you very much for the continued work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants