docs: update readme with example using multiple containers #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves readability on smaller screens and in the terminal
Describes how to use this action when the task definition contains multiple containers in the containerDefs section.
andrewlazenka
changed the title
|
Thanks for adding more documentation to the readme @ALazenka! If you don’t mind could you revert the text changes? It makes it harder to tell if there is a wording change in the text |
piradeepk
changed the title
|
@pkandasamy91 I have reverted those line break changes as requested! |
clareliguori
suggested changes
May 28, 2020
clareliguori
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #20 there is an example which shows the output of this action used as the task-definition input of another use of this action. I ran into a different use case for this type of usage today as I have a task definition which contains multiple containers which need to get updated URIs before I can deploy and update my service. Thought it would be useful to document this for other users to find.
Made a small modification to the README which describes how to use this action when the task definition contains multiple containers in the containerDefs section.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.