Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return secrets as outputs instead of values (no dist) #37

Closed
wants to merge 6 commits into from

Conversation

Olfi01
Copy link

@Olfi01 Olfi01 commented May 12, 2023

Issue #14: Environment variables vs outputs

Description of changes:
Secrets are now returned as action outputs. This results in the following improvements:

  • User side:
    • Less concern needed over which steps to separate in a different job to avoid access to environment variables
    • Full control over where the returned secrets are used
  • Codebase side:
    • No more need to clean up environment variable secrets, as the GitHub Actions toolkit will handle the outputs.

README.md, action.yml and code comments have been updated accordingly. Tests are passing.

If you prefer having the compiled files included in the PR, I have created a parallel PR (#36) containing the code changes and the built dist files.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Olfi01 Olfi01 requested a review from ecraw-amzn as a code owner May 12, 2023 12:26
@Olfi01 Olfi01 changed the title Update action to use masked outputs instead of masked environment var… Return secrets as outputs instead of values (no dist) May 12, 2023
@Olfi01
Copy link
Author

Olfi01 commented Jun 12, 2023

Since I seem to consistently fail keeping my build files out, I'll close this PR. A re-build of the TS code is still possible on the other PR.

@Olfi01 Olfi01 closed this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant