Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add resolver generation #3134

Open
wants to merge 12 commits into
base: feature/server-side-validation
Choose a base branch
from
Open

feat: add resolver generation #3134

wants to merge 12 commits into from
+861 −7

Conversation

bobbyu99
Copy link
Contributor

@bobbyu99 bobbyu99 commented Jan 29, 2025 •
edited
Loading

Description of changes

  • added generateResolvers method that generates resolver functions in CREATE and UPDATE resolver pipeline
  • added makeValidationSnippet and getValidationCheck helpers for VTL code generation
  • updated CREATE and UPDATE resolver pipeline in transformer-core/src/transformer-context/resolver.ts

Description of how you validated changes

  • unit tests for makeValidationSnippet and getValidationCheck helpers
  • unit tests for generateResolvers

Checklist

  • PR description included
  • yarn test passes
  • E2E test run linked
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Any CDK or CloudFormation parameter changes are called out explicitly

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bobbyu99 bobbyu99 changed the title feat: add resolvers generation feat: add resolver generation Jan 29, 2025
@bobbyu99 bobbyu99 marked this pull request as ready for review January 29, 2025 23:26
@bobbyu99 bobbyu99 requested review from a team as code owners January 29, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palpatim palpatim palpatim left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobbyu99 @palpatim