chore: Remove direct dependency on inflight via glob #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palpatim
previously approved these changes
Dec 6, 2023
dpilch
previously approved these changes
Dec 6, 2023
palpatim
previously approved these changes
Dec 7, 2023
phani-srikar
changed the title
phani-srikar
changed the title
palpatim
reviewed
Dec 7, 2023
| @@ -305,7 +305,7 @@ function loadSchema(apiResourcePath) { | |||
| } | |||
| if (fs.pathExistsSync(schemaDirectory) && fs.lstatSync(schemaDirectory).isDirectory()) { | |||
| // search recursively for graphql schema files inside `schema` directory | |||
| const schemas = glob.sync([path.join(schemaDirectory, '**/*.graphql')]); | |||
| const schemas = globby.sync([path.join(schemaDirectory, '**/*.graphql')].map((path) => path.replace(/\\/g, '/'))); | |||
There was a problem hiding this comment.
I believe we used node's built-in path to enforce the correct path parsing & separator in another context. I can't find the reference, but maybe @dpilch remembers?
There was a problem hiding this comment.
This is what I used to switch the separators:
palpatim
approved these changes
Dec 8, 2023
dpilch
approved these changes
Dec 8, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
globmodule that is not maintained actively withglobbythat is claimed to be much faster and is well maintained. Refer glob's author note in it's repo that recommends globbyglobbyequivaltents.yarn.lockwill still haveinflightbut we don't use it in directly in our source code viaglob.globbydoes not support back slashes in patterns, so we need to normalize the patterns to use forward slashes. We have unit tests for windows for these cases.Codegen Paramaters Changed or Added
Issue #, if available
Description of how you validated changes
Unit and E2E tests
Checklist
yarn testpassespath) behave differently on windows.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.