Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use associated fields for references on swift #815

Closed
wants to merge 1 commit into from
Closed

fix: use associated fields for references on swift #815

wants to merge 1 commit into from

Conversation

dpilch
Copy link
Member

@dpilch dpilch commented Apr 19, 2024 •
edited
Loading

Description of changes

  • Add .hasOne to relationships that use references on Swift.
  • Fix relationship that use references to use associatedFields on Swift.

Codegen Paramaters Changed or Added

N/A

Issue #, if available

N/A

Description of how you validated changes

  • Unit tests
  • Test in sample app

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dpilch dpilch marked this pull request as ready for review April 19, 2024 21:27
@dpilch dpilch requested a review from a team as a code owner April 19, 2024 21:27
@dpilch dpilch requested a review from lawmicha April 19, 2024 21:28
@dpilch dpilch enabled auto-merge (squash) April 22, 2024 17:20
@dpilch dpilch closed this Apr 24, 2024
auto-merge was automatically disabled April 24, 2024 15:05

Pull request was closed

@dpilch dpilch deleted the associated-fields branch July 31, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palpatim palpatim palpatim approved these changes

@lawmicha lawmicha Awaiting requested review from lawmicha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpilch @palpatim