chore(actions): add ci job for branch protection #12524
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue context
When a workflow is executed, if a job fails then successive jobs are skipped and the execution stops. If branch protection depends on a successive job that was skipped then it doesn't block merging. In other words a job has to fail for branch protection to block merging
Github docs: Require status checks before merging
Description of changes
Add an additional
ci
job, that will always run and would either pass / fail (cannot be skipped) based on required checksOther solutions considered
update-success
andupdate-failure
which would only run on success and failure respectively (amplify-ui reference)On the amplify-ui repository, on PR we run test-fork-prs / test-internal-prs. These have two jobs at the end update-success-status and update-failure-status.
Description of how you validated changes
Tested on fork
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.