feat(storage): add new internal downloadData api #13887
Open
+243
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinkumar6
requested review from
haverchuck,
cshfang,
jimblanc,
HuiSF and
a team
as code owners
ashwinkumar6
commented
Oct 4, 2024
| // TODO: Remove this interface when we move to public advanced APIs. | ||
| import { DownloadDataInput as DownloadDataWithPathInputWithAdvancedOptions } from '../../../../internals/types/inputs'; | ||
|
|
||
| export const downloadData = ( |
There was a problem hiding this comment.
other src/providers/s3/apis/internal/<api> take Amplify singleton as their first input param. We haven't added it here because downloadData isn't supported in SSR and hence isn't required atm
ashwinkumar6
commented
Oct 4, 2024
| @@ -0,0 +1,90 @@ | |||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
existing code moved as is with the addition of DownloadDataWithPathInputWithAdvancedOptions type in input.
| * @internal | ||
| */ | ||
| export const downloadData = (input: DownloadDataInput): DownloadDataOutput => | ||
| downloadDataInternal({ |
There was a problem hiding this comment.
Why not just pass down the whole input?
There was a problem hiding this comment.
There was a discussion this is better ATM
ashika112
reviewed
Oct 4, 2024
ashika112
reviewed
Oct 4, 2024
added 2 commits
October 4, 2024 16:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
src/providers/s3/apis/downloadData.tstosrc/providers/s3/apis/internal/downloadData.tssrc/internals/apis/downloadData.tsDescription of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.