-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade webpack to version 2 #316
Conversation
Codecov Report
@@ Coverage Diff @@
## master #316 +/- ##
=======================================
Coverage 90.29% 90.29%
=======================================
Files 53 53
Lines 2556 2556
Branches 521 521
=======================================
Hits 2308 2308
Misses 237 237
Partials 11 11 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not very familiar with this issue. Can Amplify team member review this too?
@powerful23 can you make these updates as part of the build updates in amplify? |
@mlabieniec ok |
Closing this as cognito sdk is currently using webpack version 3.5.5. Please feel free to re-open the PR if there are any concerns. |
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
Description of changes:
Upgrade webpack to version 2 in order to fix the build issues of #309.
loaders
torules
.-loader
tobabel
as it cannot be omitted anymore.OccurrenceOrderPlugin
as it is now included by default.BannerPlugin
following new function signature.source-map
as it is now disabled by default.warning: false
entry as it is now disabled by default.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.