Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade webpack to version 2 #316

Closed
wants to merge 2 commits into from

Conversation

digigarlab
Copy link

Issue #, if available:

Description of changes:

Upgrade webpack to version 2 in order to fix the build issues of #309.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Feb 20, 2018

Codecov Report

Merging #316 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #316   +/-   ##
=======================================
  Coverage   90.29%   90.29%           
=======================================
  Files          53       53           
  Lines        2556     2556           
  Branches      521      521           
=======================================
  Hits         2308     2308           
  Misses        237      237           
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ceec3cd...48c5419. Read the comment docs.

Copy link
Contributor

@yuntuowang yuntuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not very familiar with this issue. Can Amplify team member review this too?

@mlabieniec
Copy link
Contributor

@powerful23 can you make these updates as part of the build updates in amplify?

@mlabieniec mlabieniec requested review from powerful23 and removed request for mreddyg April 20, 2018 17:43
@mlabieniec mlabieniec assigned powerful23 and unassigned mreddyg Apr 20, 2018
@powerful23
Copy link
Contributor

@mlabieniec ok

@nidsharm
Copy link

Closing this as cognito sdk is currently using webpack version 3.5.5. Please feel free to re-open the PR if there are any concerns.

@nidsharm nidsharm closed this Oct 22, 2018
@digigarlab digigarlab deleted the upgrade-webpack-2 branch October 23, 2018 10:10
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants