Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for the ec2 protocol #170

Merged

Conversation

cheese-head
Copy link
Contributor

These changes would allow for support of the ec2 protocol. There's also a pending pull request in the aws-codegen repo that would need to be approved. aws-beam/aws-codegen#100

@cheese-head cheese-head mentioned this pull request Nov 27, 2023
@onno-vos-dev
Copy link
Member

Will review later during the day but letting pipelines run in the meantime 👌 Thank you for the PR's already! <3

@onno-vos-dev
Copy link
Member

Rebased on latest master due to your previous build not compiling since inspector_scan.ex generated warnings since there were no operations on it.

@onno-vos-dev
Copy link
Member

I apologise for the delay on both this PR as well as aws-beam/aws-codegen#100. Private life got in the way 😢

Took care of everything now and will try to roll out a new release tomorrow 👌

@onno-vos-dev onno-vos-dev merged commit dd8bf8c into aws-beam:master Dec 15, 2023
2 checks passed
@cheese-head
Copy link
Contributor Author

@onno-vos-dev Any chance you can have a new release pushed to hex for these changes? Thanks!

@onno-vos-dev
Copy link
Member

onno-vos-dev commented Jan 5, 2024

@cheese-head Sorry I totally missed this one.

On it! Will ping you in about 20-30 minutes!

@onno-vos-dev
Copy link
Member

@cheese-head https://hex.pm/packages/aws/0.14.0 Done! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants