-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DBClusterEndpoint] Create new resource #200
Merged
khebul
merged 46 commits into
aws-cloudformation:master
from
khebul:db-cluster-endpoint
Jun 15, 2022
Merged
[DBClusterEndpoint] Create new resource #200
khebul
merged 46 commits into
aws-cloudformation:master
from
khebul:db-cluster-endpoint
Jun 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndler implemented
osdrv
previously approved these changes
Jun 1, 2022
aws-rds-cfn-common/src/main/java/software/amazon/rds/common/test/AbstractTestBase.java
Show resolved
Hide resolved
I'm pretty happy with this implementation. Please fix the missing bits. You are certainly on the right track! |
…perties create-only since their modification causes interruption of service
…ment strategy to delete_then_create
osdrv
reviewed
Jun 5, 2022
...ds-dbclusterendpoint/src/main/java/software/amazon/rds/dbclusterendpoint/BaseHandlerStd.java
Outdated
Show resolved
Hide resolved
...ds-dbclusterendpoint/src/main/java/software/amazon/rds/dbclusterendpoint/BaseHandlerStd.java
Outdated
Show resolved
Hide resolved
...rds-dbclusterendpoint/src/main/java/software/amazon/rds/dbclusterendpoint/DeleteHandler.java
Show resolved
Hide resolved
aws-rds-dbclusterendpoint/src/main/java/software/amazon/rds/dbclusterendpoint/Translator.java
Outdated
Show resolved
Hide resolved
aws-rds-dbclusterendpoint/src/main/java/software/amazon/rds/dbclusterendpoint/Translator.java
Outdated
Show resolved
Hide resolved
...rds-dbclusterendpoint/src/main/java/software/amazon/rds/dbclusterendpoint/UpdateHandler.java
Outdated
Show resolved
Hide resolved
...clusterendpoint/src/test/java/software/amazon/rds/dbclusterendpoint/AbstractHandlerTest.java
Outdated
Show resolved
Hide resolved
moataz-mhmd
reviewed
Jun 7, 2022
...ds-dbclusterendpoint/src/main/java/software/amazon/rds/dbclusterendpoint/BaseHandlerStd.java
Show resolved
Hide resolved
...rds-dbclusterendpoint/src/main/java/software/amazon/rds/dbclusterendpoint/CreateHandler.java
Show resolved
Hide resolved
...rds-dbclusterendpoint/src/main/java/software/amazon/rds/dbclusterendpoint/UpdateHandler.java
Show resolved
Hide resolved
…ties, added Invalid State handling
osdrv
reviewed
Jun 7, 2022
aws-rds-dbclusterendpoint/contract-test-required-resources.template.yaml
Outdated
Show resolved
Hide resolved
...ds-dbclusterendpoint/src/main/java/software/amazon/rds/dbclusterendpoint/BaseHandlerStd.java
Show resolved
Hide resolved
...ds-dbclusterendpoint/src/main/java/software/amazon/rds/dbclusterendpoint/BaseHandlerStd.java
Outdated
Show resolved
Hide resolved
...rds-dbclusterendpoint/src/main/java/software/amazon/rds/dbclusterendpoint/CreateHandler.java
Outdated
Show resolved
Hide resolved
...rds-dbclusterendpoint/src/main/java/software/amazon/rds/dbclusterendpoint/DeleteHandler.java
Outdated
Show resolved
Hide resolved
...dbclusterendpoint/src/test/java/software/amazon/rds/dbclusterendpoint/CreateHandlerTest.java
Outdated
Show resolved
Hide resolved
...dbclusterendpoint/src/test/java/software/amazon/rds/dbclusterendpoint/DeleteHandlerTest.java
Show resolved
Hide resolved
...ds-dbclusterendpoint/src/test/java/software/amazon/rds/dbclusterendpoint/TranslatorTest.java
Outdated
Show resolved
Hide resolved
...dbclusterendpoint/src/test/java/software/amazon/rds/dbclusterendpoint/UpdateHandlerTest.java
Outdated
Show resolved
Hide resolved
...dbclusterendpoint/src/test/java/software/amazon/rds/dbclusterendpoint/UpdateHandlerTest.java
Outdated
Show resolved
Hide resolved
osdrv
reviewed
Jun 14, 2022
...rds-dbclusterendpoint/src/main/java/software/amazon/rds/dbclusterendpoint/CreateHandler.java
Show resolved
Hide resolved
osdrv
approved these changes
Jun 14, 2022
moataz-mhmd
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #199
Create new resource
AWS::RDS::DBClusterEndpoint
that represents Aurora Cluster Endpoint. The resource always require replacement.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.