Adding Jest tests into a test stage #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jaysonmc
commented
Apr 19, 2023
jaysonmc
commented
- Adding npm install to README (missing step)
- Introducing a test stage (single action) to run the existing Jest tests and generate a CodeBuild report
SourceArtifact => sourceArtifact
indrora
reviewed
Jun 21, 2023
| @@ -22,6 +23,8 @@ phases: | |||
| - sed -i "s|EXECUTION_ROLE_ARN|${EXECUTION_ROLE_ARN}|g" taskdef.json | |||
| - sed -i "s|TASK_DEFINITION_ARN|${TASK_DEFINITION_ARN}|g" appspec.yaml | |||
| - cat appspec.yaml && cat taskdef.json | |||
| - mv appspec.yaml ../ | |||
There was a problem hiding this comment.
Should be copy, not move, or the file should be there to begin with.
I'd suggest outputting to a new file rather than modifying the file in-situ with sed.
There was a problem hiding this comment.
The sed part is not part of this PR. Though if we'd like to address, would make for a good new issue.
Regarding the move. I tried to reference the file not from root and it didn't work. I can take another swing at that one, though.
Oh, I missed the recommendation for copy (thought it was not move at all). Read to quickly. Updated.
kaiz-io
reviewed
Jul 31, 2023
| branch: "main", | ||
| output: sourceArtifact, | ||
| output: SourceArtifact, |
There was a problem hiding this comment.
Looks like you meant this to be lowercase
Suggested change
| output: SourceArtifact, | |
| output: sourceArtifact, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.