Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: test build only on changed code #867

Merged
merged 3 commits into from
Jun 27, 2023
Merged

feat: test build only on changed code #867

merged 3 commits into from
Jun 27, 2023

Conversation

kaiz-io
Copy link
Contributor

@kaiz-io kaiz-io commented Jun 20, 2023

This PR fixes the CI build process to only attempt to synth cdk apps that have code that actually changed, instead of building all of apps for a particular language.

Fixes #


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

mmaeng
mmaeng previously approved these changes Jun 20, 2023
Copy link
Contributor

@mmaeng mmaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot dismissed mmaeng’s stale review June 23, 2023 01:01

Pull request has been modified.

indrora
indrora previously approved these changes Jun 27, 2023
@mergify mergify bot dismissed indrora’s stale review June 27, 2023 21:20

Pull request has been modified.

ericzbeard
ericzbeard previously approved these changes Jun 27, 2023
@@ -59,35 +75,3 @@ jobs:
esac
done

build:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step needs to be there for CI to work.

Find a way to get $path2 over here.

@mergify mergify bot dismissed stale reviews from ericzbeard and indrora June 27, 2023 22:10

Pull request has been modified.

@mergify mergify bot merged commit 8b650ce into aws-samples:master Jun 27, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

Thank you for contributing! Your pull request is now being automatically merged.

kellertk added a commit that referenced this pull request Jun 30, 2023
indrora pushed a commit that referenced this pull request Jun 30, 2023
* Revert "fix: github set-output deprecated (#871)"

This reverts commit b98918d.

* Revert "feat: test build only on changed code all commits (#869)"

This reverts commit 0cf785b.

* Revert "feat: test build only on changed code (#867)"

This reverts commit 8b650ce.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants