Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updates to ec2 Example #895

Merged
merged 3 commits into from
Jul 31, 2023
Merged

fix: updates to ec2 Example #895

merged 3 commits into from
Jul 31, 2023

Conversation

schuettc
Copy link

This changes updates an older example for creating an EC2 instance and includes examples for using UserData and CloudInit. This also includes an option for configuring SSH.

Fixes #

#853


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@ericzbeard ericzbeard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, can you go back through and add code comments above classes, functions, and code blocks? This will make it easier for people to understand the example, and also make better food for generative AI training.

@schuettc
Copy link
Author

Updated with comments

ericzbeard
ericzbeard previously approved these changes Jul 31, 2023
@ericzbeard ericzbeard enabled auto-merge (squash) July 31, 2023 15:27
@ericzbeard
Copy link
Contributor

Not sure why this PR isn't merging...

@mmaeng
Copy link
Contributor

mmaeng commented Jul 31, 2023

Testing a few things to see why this isn't merging.

@mmaeng mmaeng closed this Jul 31, 2023
auto-merge was automatically disabled July 31, 2023 18:07

Pull request was closed

@mmaeng mmaeng reopened this Jul 31, 2023
@mergify mergify bot dismissed ericzbeard’s stale review July 31, 2023 18:08

Pull request has been modified.

@mmaeng
Copy link
Contributor

mmaeng commented Jul 31, 2023

Looks like the process just had to get kicked for the statuses to report back correctly.

@mmaeng mmaeng merged commit 9b6d307 into aws-samples:master Jul 31, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants