Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allways allow access to data collection bucket for account map access #656

Merged
merged 2 commits into from
Nov 7, 2023
Merged

allways allow access to data collection bucket for account map access #656

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8bca67
allways allow access to data collection bucket for account map access
iakov-aws Oct 28, 2023
9acb8a8
better conditions
iakov-aws Oct 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions cfn-templates/cid-cfn.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,10 +266,6 @@ Conditions:
Fn::And:
- !Condition NeedQuickSightDataSourceRole
- !Condition NeedCUR
NeedQuickSightDataSourceRoleAndODC:
Fn::And:
- !Condition NeedQuickSightDataSourceRole
- !Condition NeedDataCollectionLab

Resources:
SpiceRefreshExecutionRole: #Role needed to schedule spice ingestion for the datasets
Expand Down Expand Up @@ -787,7 +783,7 @@ Resources:

ProcessedODCPath:
Type: Custom::CustomResourceProcessPath
Condition: NeedDataCollectionLab
#Condition: NeedDataCollectionLab #Need to process ODC lab path regardless dashboards. CUR dashboards need ODC for account map
Properties:
ServiceToken: !GetAtt CustomResourceProcessPath.Arn
s3path: !Ref OptimizationDataCollectionBucketPath
Expand Down Expand Up @@ -1079,7 +1075,7 @@ Resources:

QuickSightDataSourceRolePolicyForODCBucket:
Type: AWS::IAM::Policy
Condition: NeedQuickSightDataSourceRoleAndODC
Condition: NeedQuickSightDataSourceRole # We need ODC bucket even if ODC dashboards are not activated (ex: for account map)
Properties:
PolicyName: QuickSightDataSource-S3AccessODC
PolicyDocument:
Expand Down