Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude known views and enforce naming #693

Merged
merged 2 commits into from
Nov 20, 2023
Merged

exclude known views and enforce naming #693

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb58434
exclude known views and enforce naming
iakov-aws Nov 18, 2023
772ef85
minor fixes
iakov-aws Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions cid/export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,12 @@ def export_analysis(qs, athena):
value['RelationalTable']['Schema'] = '${athena_database_name}'
athena_source = value['RelationalTable']['Name']
views_name = athena_source.split('.')[-1]
dependency_views.append(views_name)
all_views.append(views_name)
if views_name in athena._resources.get('views') and not get_parameters().get('export-known-datasets'):
logger.debug(f'Athena viw {views_name} is in resources. Skipping')
continue
else:
dependency_views.append(views_name)
all_views.append(views_name)
elif 'CustomSql' in value and 'DataSourceArn' in value['CustomSql']:
logger.debug(f"Dataset {dataset.raw['DataSetId']} looks like CustomSql athena dataset")
value['CustomSql']['DataSourceArn'] = '${athena_datasource_arn}'
Expand Down Expand Up @@ -250,9 +254,13 @@ def export_analysis(qs, athena):
logger.debug('Building dashboard resource')
dashboard_id = get_parameter(
'dashboard-id',
message='dashboard id (will be used in url of dashboard)',
default=escape_id(analysis['Name'].lower())
message='dashboard id (will be used in dashboard URL. Use lowercase, hyphens(not underscores) and make it short but understandable for humans)',
default=escape_id(analysis['Name'].lower().replace(' ', '-').replace('_', '-'))
)
new_dashboard_id = dashboard_id.lower().replace(' ', '-').replace('_', '-')
if dashboard_id != new_dashboard_id:
cid_print('Best practices enforced: {dashboard_id} -> {new_dashboard_id}')
dashboard_id = new_dashboard_id

dashboard_resource = {}
dashboard_resource['dependsOn'] = {
Expand Down