Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change wording form layered to cross-stack references #253

Merged
merged 5 commits into from
Nov 21, 2023

Conversation

rezabekf
Copy link
Contributor

@rezabekf rezabekf commented Nov 14, 2023

What does this PR do and why?

This PR changes the wording to be consistent with AWS terminology.

Issue #, if available

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • Added/Updated documentation if applicable.
  • Pre-commit checks passed.
  • Lint and Nag checks passed.
  • If releasing a new version, have you bumped the version make version part=<major|minor|patch>?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rezabekf rezabekf self-assigned this Nov 14, 2023
@rezabekf rezabekf requested a review from a team as a code owner November 14, 2023 18:34
Copy link
Contributor

@mrinaudo-aws mrinaudo-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rezabekf - please fix the typo to which I am pointing in my suggestion, otherwise LGTM.

content/intermediate/templates/cross-stacks/index.md Outdated Show resolved Hide resolved
@rezabekf
Copy link
Contributor Author

@cmick-aws, could you please review Japanese translation for this change? I have updated static files links, however the text will need to be done by you or your team. Thank you!

Copy link
Contributor

@mrinaudo-aws mrinaudo-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rezabekf rezabekf merged commit 124f279 into main Nov 21, 2023
1 check passed
@rezabekf rezabekf deleted the fix/rename-layered-to-cross-stacks branch November 21, 2023 14:15
@cmick-aws
Copy link
Contributor

@rezabekf , Please let me apply corresponding changes to the other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants