Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed msk-lambda-iam-java-sam.json file. Removed reference to non-fun… #2590

Merged
merged 2 commits into from
Feb 4, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions msk-lambda-iam-java-sam/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,8 @@ The sam deploy command will package and deploy your application to AWS, with a s
* **SAM configuration environment [default]**: Environment for storing deployment information locally

You should get a message "Successfully created/updated stack - <StackName> in <Region>" if all goes well

**Note: In case you want to deploy the Lambda function by pointing to an existing MSK Cluster and not the one created by running the CloudFormation template provided in this pattern, you will need to modify the values of the parameters MSKClusterName and MSKClusterId accordingly**


## Test the sample application
Expand Down
8 changes: 2 additions & 6 deletions msk-lambda-iam-java-sam/example-pattern.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
"headline": "How it works",
"text": [
"This pattern provides a Lambda function along with an Event Source Mapping to a Kafka topic.",
"It requires that you already have an Amazon Managed Streaming for Kafka (Amazon MSK) cluster setup with a topic created. ",
"If you don't already have an MSK cluster, you can use the example in this pattern https://serverlessland.com/patterns/msk-cfn-sasl-lambda (linked in the resources) to deploy a cluster.",
"The Lambda function requires that you already have an Amazon Managed Streaming for Kafka (Amazon MSK) cluster setup with a Kafka topic created. ",
"In this pattern, an AWS CloudFormation template is provided, that installs an Amazon MSK cluster and also creates a Kafka topic.",
"This pattern works with either a Provisioned or Serverless MSK cluster as long as the cluster is configured to use IAM authentication. ",
"For detailed deployment instructions instructions see the README."
]
Expand All @@ -24,10 +24,6 @@
},
"resources": {
"bullets": [
{
"text": "Amazon MSK cluster pattern",
"link": "https://serverlessland.com/patterns/msk-cfn-sasl-lambda"
},
{
"text": "Using AWS Lambda with Amazon MSK",
"link": "https://docs.aws.amazon.com/lambda/latest/dg/with-msk.html"
Expand Down
3 changes: 1 addition & 2 deletions msk-lambda-iam-java-sam/msk-lambda-iam-java-sam.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@
"headline": "How it works",
"text": [
"This pattern provides a Lambda function along with an Event Source Mapping to a Kafka topic.",
"It requires that you already have an Amazon Managed Streaming for Kafka (Amazon MSK) cluster setup with a topic created. ",
"If you don't already have an MSK cluster, you can use the example in this pattern https://serverlessland.com/patterns/msk-cfn-sasl-lambda (linked in the resources) to deploy a cluster.",
"It provides a Cloudformation template that creates an Amazon Managed Streaming for Kafka (Amazon MSK) cluster.",
"This pattern works with either a Provisioned or Serverless MSK cluster as long as the cluster is configured to use IAM authentication. ",
"For detailed deployment instructions instructions see the README."
]
Expand Down