Target allocator #261
Open
Target allocator #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mitali Salvi <[email protected]>
* Ta https server (#2921) * Added https server, tests, secret marshalling --------- Co-authored-by: ItielOlenick <[email protected]>
…247) * edited workflow
* Reconciler now removes un-used managed resources for CWA collector
* added one-service per TA
* TLS tests
* Injecting Prom path if it doesn't exist
* Adding support for NodeJS auto instrumentation and integ tests (#220) * Support configurable resources for NodeJS. (#225) * Supporting JMX annotations (#240) * Add support for a supplemental YAML configuration for the CloudWatchAgent (#241) * Changed naming for OTLP container ports from agent JSON (#252) * Updated Release Notes for 1.8.0 (#251) * Adjust EKS add-on integration test service count expectations (#256) * Add integration tests for JMX. (#250) * Implemented Target Allocator Container (#214) * Implemented TargetAllocator resource deployments. (#208) * Update cmd/amazon-cloudwatch-agent-target-allocator/config/config.go Co-authored-by: Musa <[email protected]> * Update internal/config/main.go Co-authored-by: Musa <[email protected]> --------- Co-authored-by: Parampreet Singh <[email protected]> Co-authored-by: Musa <[email protected]> Co-authored-by: Mitali Salvi <[email protected]> Co-authored-by: Jeffrey Chien <[email protected]>
okankoAMZ
commented
Nov 12, 2024
okankoAMZ
force-pushed
the
target-allocator
branch
3 times, most recently
from
d59fed3
to
a1a0f2c
Compare
okankoAMZ
force-pushed
the
target-allocator
branch
from
a1a0f2c
to
50e29f0
Compare
lisguo
reviewed
Nov 14, 2024
lisguo
previously approved these changes
Nov 14, 2024
sky333999
reviewed
Nov 15, 2024
cmd/amazon-cloudwatch-agent-target-allocator/allocation/allocator.go
Outdated
Show resolved
Hide resolved
| @@ -9,6 +9,16 @@ func ConfigMap(otelcol string) string { | |||
| return DNSName(Truncate("%s", 63, otelcol)) | |||
| } | |||
|
|
|||
| // TAConfigMap returns the name for the config map used in the TargetAllocator. | |||
| func TAConfigMap(otelcol string) string { | |||
| return DNSName(Truncate("%s-target-allocator", 63, otelcol)) | |||
There was a problem hiding this comment.
nit: %s-targetallocator to be consistent with upstream
There was a problem hiding this comment.
we are following the cloudwatch-agent format here but I am open to changing
|
|
||
| // PrometheusConfigMap returns the name for the prometheus config map. | ||
| func PrometheusConfigMap(otelcol string) string { | ||
| return DNSName(Truncate("%s-prometheus-config", 63, otelcol)) |
There was a problem hiding this comment.
nit: %s-prometheus is probably good enough to be consistent with the other names and its better to keep these short to avoid hitting the max length of 64.
| ) | ||
|
|
||
| // Labels return the common labels to all TargetAllocator objects that are part of a managed AmazonCloudWatchAgent. | ||
| func Labels(instance v1alpha1.AmazonCloudWatchAgent, name string) map[string]string { |
There was a problem hiding this comment.
nit: Do we need this?
Cant we just call manifestutils.Labels with a new component name like ComponentAmazonCloudWatchAgentTargetAllocator?
There was a problem hiding this comment.
We don't need it, we can remove it and use manifestutils.Labels instead if that's preferable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced CloudWatch Agent Operator for Kubernetes
Summary
This PR introduces significant improvements to the CloudWatch Agent Operator for Kubernetes, addressing limitations in the previous Daemonset implementation and enhancing scalability and efficiency.
Key Changes
Detailed Description
Background
The Amazon CloudWatch Agent allows customers to collect and publish metrics in Prometheus format across various compute environments, including Kubernetes clusters. The CloudWatch Agent Operator simplifies the onboarding process for Prometheus scraping.
Previous Limitations
New Features
Statefulset Deployment:
Target Allocator Integration:
Benefits:
Automatic Updates
The operator automatically applies changes to the scrape configuration, updating both the Target Allocator and CloudWatch Agent instances.
Testing
TBA
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.