Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI examples for ec2, ecs, ivs-realtime, lambda #9179

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

elysahall
Copy link
Collaborator

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@elysahall elysahall added documentation This is a problem with documentation. pr:needs-review This PR needs a review from a Member. labels Dec 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.08%. Comparing base (32ecf80) to head (36b8128).
Report is 14 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #9179   +/-   ##
=======================================
  Coverage     0.08%   0.08%           
=======================================
  Files          210     210           
  Lines        16984   16984           
=======================================
  Hits            14      14           
  Misses       16970   16970           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashovlin ashovlin self-assigned this Jan 13, 2025

aws ecs discover-poll-endpoint \
--container-instance d5f596ccb5794833b778c680c318ft78 \
--cluster-name MyCluster
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see --cluster-name on https://awscli.amazonaws.com/v2/documentation/api/latest/reference/ecs/discover-poll-endpoint.html, should it be --cluster?

Also while you're here, could you indent the JSON output?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, just saw the service note

This action is only used by the Amazon ECS agent, and it is not intended for use outside of the agent.

Should we still have an example if ECS isn't expecting users to call it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation. pr:needs-review This PR needs a review from a Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants