Refine SSO configure prompt titles #9203
Conversation
| "category": "sso", | ||
| "description": "cosmetics changes for better clarity" |
There was a problem hiding this comment.
This ends up in the changelog. Try to pretty explicit about what is changing, we don't need to be too brief.
| "category": "sso", | |
| "description": "cosmetics changes for better clarity" | |
| "category": "``configure``" | |
| "description": "Clarify prompt titles and default values in the ``aws configure sso`` wizard" |
| config = profile_map[profile_name] | ||
| if 'output' not in config: | ||
| config['output'] = 'json' | ||
| return config |
There was a problem hiding this comment.
I'd avoid this if possible. We're setting the default value here:
Line 304 in 14e84b6
We should strive to keep a single source-of-truth and avoid handling specific properties in an otherwise generic method.
Where possible it's also nice to avoid CLI-specific code in the botocore folder, to ease porting updates from actual botocore.
| if config_name == 'output' and not current_value: | ||
| current_value = 'json' |
There was a problem hiding this comment.
Is this going to persist output = json in the profile which we don't do today?
If so, I'd try to avoid a change in behavior with a quick cosmetic change, largely so we don't have to hunt down all of the implications.
- If using
current_value->new_value, is there a way to not persist it if the user just pressed enter to accept the default. - Or, can we just communicate the default behavior through the
textandprompt_fmtstrings, then still actually collect and "save"None?
Issue #, if available:
Description of changes:
aws configure ssoexample command #9132By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.