-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request response samples #613
base: RequestResponseWorkspace
Are you sure you want to change the base?
Conversation
…identity sandbox samples
…m and look inside
The links in the main samples README.md need to be updated/removed. The clicking on any of the deprecated samples from the sample selection list goes to 404. New samples should also be added to the main sample README.md. |
@@ -35,8 +35,8 @@ android { | |||
java.srcDir '../../Utils/CommandLineUtils' | |||
java.srcDir '../../Mqtt5/PubSub/src/main/java' | |||
java.srcDir '../../BasicPubSub/src/main/java' | |||
java.srcDir '../../Jobs/src/main/java' | |||
java.srcDir '../../Shadow/src/main/java' | |||
java.srcDir '../../deprecated/Jobs/src/main/java' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These being deprecated, should we simply remove them entirely from the Android sample app so people don't use them?
|
||
You can also use any certificate set you've already created if it has sufficient IoT permissions. If you wish to do this, you can skip the step that calls `create-provisioning-claim` below and move right to the next step: [Running the sample using a certificate-key set](#running-the-sample-using-a-certificate-key-set) | ||
|
||
We've included a script in the utils folder that creates certificate and key files from the response of calling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trivial: We should link the script here for convenience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link updates in landing Samples README.md aside, looks good. Great documentation of the samples!
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.